Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-18437: Correct version of ShareUpdateRecord value #18423

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

AndrewJSchofield
Copy link
Member

The versions of coordinator record keys are hijacked to distinguish between the record types. Coordinator record values are always version 0.

The JSON schema definition of ShareUpdateRecord uses version 0, but the version number used when constructing the record was version 1.

This patch applies to AK 4.0 only because this code has been superseded and the error was already been fixed.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@AndrewJSchofield AndrewJSchofield requested a review from dajac January 7, 2025 18:49
@chia7712
Copy link
Member

chia7712 commented Jan 7, 2025

the ShareUpdateKey file has validVersions=1 in 4.0 but "validVersions=0" in trunk. It is fine as we don't use the version to check serialized field. Also, we won't bump the version for those coordinator-keys. However, it is still a weird thing to have two different validVersions for same record. Maybe we can add some comments to the json file in 4.0?

@AndrewJSchofield
Copy link
Member Author

the ShareUpdateKey file has validVersions=1 in 4.0 but "validVersions=0" in trunk. It is fine as we don't use the version to check serialized field. Also, we won't bump the version for those coordinator-keys. However, it is still a weird thing to have two different validVersions for same record. Maybe we can add some comments to the json file in 4.0?

This is true for all of the key schemas in the group coordinator in 4.0 too, such as ConsumerGroupCurrentMemberAssignmentKey.

@AndrewJSchofield AndrewJSchofield added the KIP-932 Queues for Kafka label Jan 8, 2025
Copy link
Member

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AndrewJSchofield AndrewJSchofield merged commit 921b7fe into apache:4.0 Jan 9, 2025
8 of 9 checks passed
@AndrewJSchofield AndrewJSchofield deleted the KAFKA-18437 branch January 9, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
KIP-932 Queues for Kafka
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants