MINOR: improve StreamThread periodic processing log #18430
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ableegoldman
reviewed
Jan 8, 2025
| totalRecordsProcessedSinceLastSummary, totalPunctuatorsSinceLastSummary, totalCommittedSinceLastSummary); | ||
| final long timeSinceLastLog = now - lastLogSummaryMs; | ||
| if (logSummaryIntervalMs > 0 && timeSinceLastLog > logSummaryIntervalMs) { | ||
| log.info("Processed {} total records, ran {} punctuators, polled {} times and committed {} total tasks since the last update {}ms ago", |
There was a problem hiding this comment.
can we also log how long it's been since the last update? we just merged a KIP to allow configuring this interval, and anyways the time can vary and the logging interval is just a minimum not exact interval
There was a problem hiding this comment.
oh my bad...you already did...
(great minds think alike...?)
ableegoldman
approved these changes
Jan 8, 2025
|
Merged to trunk and cherrypicked to 4.0 |
ableegoldman
pushed a commit
that referenced
this pull request
Jan 9, 2025
The current log is really helpful, this PR adds a bit more information to that log to help debug some issues. In particular, it is interesting to be able to debug situations that have long intervals between polls. It also includes a reference to how long it has been since it last logged so you don't have to find the previous time it was logged to compute quick per-second ratios. Reviewers: Anna Sophie Blee-Goldman <[email protected]>
|
Cherrypicked to 3.9 as well |
ableegoldman
pushed a commit
that referenced
this pull request
Jan 9, 2025
The current log is really helpful, this PR adds a bit more information to that log to help debug some issues. In particular, it is interesting to be able to debug situations that have long intervals between polls. It also includes a reference to how long it has been since it last logged so you don't have to find the previous time it was logged to compute quick per-second ratios. Reviewers: Anna Sophie Blee-Goldman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current log is really helpful, this PR adds a bit more information to that log to help debug some issues. In particular, it is interesting to be able to debug situations that have long intervals between polls. It also includes a reference to how long it has been since it last logged so you don't have to find the previous time it was logged to compute quick per-second ratios.