Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Convert BrokerEndPoint to record #18577

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

ijuma
Copy link
Member

@ijuma ijuma commented Jan 16, 2025

Tests for this class is being removed via #18573 - making it
a record avoids the need for the tests being removed.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added core Kafka Broker small Small PRs labels Jan 16, 2025
@ijuma ijuma changed the title Convert BrokerEndPoint to record MINOR: Convert BrokerEndPoint to record Jan 16, 2025
@ijuma ijuma mentioned this pull request Jan 16, 2025
3 tasks
@ijuma ijuma force-pushed the convert-broker-end-point-to-record branch from af06429 to 4304d26 Compare January 16, 2025 14:35
Copy link
Member

@AndrewJSchofield AndrewJSchofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ijuma ijuma merged commit b90ef86 into apache:trunk Jan 17, 2025
7 of 9 checks passed
@ijuma ijuma deleted the convert-broker-end-point-to-record branch January 17, 2025 15:08
askew pushed a commit to askew/kafka that referenced this pull request Jan 23, 2025
Tests for this class is being removed via apache#18573 - making it
a record avoids the need for the tests being removed.

Reviewers: Andrew Schofield <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Kafka Broker small Small PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants