Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: add removed controller metrics to zk2kraft #18654

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
+36 −31
Open

MINOR: add removed controller metrics to zk2kraft #18654

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f0851a3
MINOR: add removed controller metrics to zk2kraft
FrankYang0529 Jan 21, 2025
d408a10
address comment
FrankYang0529 Jan 21, 2025
58ffbc1
address comment
FrankYang0529 Jan 23, 2025
48efac8
Merge branch 'trunk' into minor-add-removed-metrics-to-zk2kraft
FrankYang0529 Jan 24, 2025
9e2e62e
address comment
FrankYang0529 Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions docs/zk2kraft.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,14 +155,15 @@ <h5 class="anchor-heading">Removal metrics</h5>
</li>
<li>
<p>
Remove the metrics which is monitoring the latency in milliseconds for ZooKeeper requests from broker.
Remove the metrics which are only used in ZooKeeper mode.
</p>
<ul>
<li><code>kafka.server:type=ZooKeeperClientMetrics,name=ZooKeeperRequestLatencyMs</code></li>
<li><code>kafka.controller:type=ControllerChannelManager</code></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we list complete metrics attributes? It would be useful to search specific metrics. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18658 add complete metrics, so I think PR should follow that pattern too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will follow it. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it. Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge all metrics item into single one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are three listed items for now

<li><code>kafka.controller:type=ControllerEventManager</code></li>
<li><code>kafka.controller:type=KafkaController</code></li>
<li><code>kafka.controller:type=ControllerStats</code></li>
</ul>
<p>
In Kraft mode, Zookeeper is not used, so the metrics is removed.
</p>
</li>
</ul>
</div>
Loading