KAFKA-18617 Allow use of ClusterInstance inside BeforeEach #18662
+71
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
smjn
reviewed
Jan 21, 2025
| @@ -0,0 +1,38 @@ | |||
| package org.apache.kafka.common.test.api; | |||
|
|
|||
| import org.junit.jupiter.api.BeforeEach; | |||
|
@cmccabe can you take a quick look at this one? |
|
This should probably go in after #18602 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the ClusterTest setup callback to
BeforeEachCallbackinstead ofBeforeTestExecutionCallback. This allows the setup to happen slightly earlier and before any@BeforeEachmethods are invoked.We cannot inject ClusterInstance into a
@BeforeEachmethod, but we can still use the constructor injection which allows a@BeforeEachfixture to access the ClusterInstance. This enables tests to do some common cluster setup (like creating topics) before each test case.No changes were made to
@AfterEachor our ClusterTest teardown logic.