MINOR: prevent exception from HdrHistogram #18674
Open
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkbkim
added
the
KIP-848
dajac
reviewed
Jan 23, 2025
| @@ -125,6 +127,6 @@ public List<NamedMeasurable> stats() { | |||
|
|
|||
| @Override | |||
| public void record(MetricConfig config, double value, long timeMs) { | |||
| hdrHistogram.record((long) value); | |||
| hdrHistogram.record(Math.min(highestTrackableValue, (long) value)); | |||
There was a problem hiding this comment.
Should we add a unit test for this change in KafkaMetricHistogramTest
?
There was a problem hiding this comment.
out of curiosity, HdrHistogram is the wrap of HdrHistogram API, so maybe we can move this protection into HdrHistogram?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HdrHistogram can throw an exception if the recorded value is greater than a configured limit. Expand the ceiling from per-metric to all invocations. Using existing test.
Committer Checklist (excluded from commit message)