KAFKA-18494-2: Bugfix in sharePartition. Added gapsAfterInitialization that store the first offsets of all gaps during share partition initialization #18677
+220
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n that store the first offsets of all gaps during share partition initialization
github-actions
bot
added
triage
smjn
reviewed
Jan 23, 2025
| * This maintains the set of gaps in the cachedState after initialization. Some of these gaps might correspond to batches | ||
| * which were fetched but not acknowledged yet. The gaps are used in determining the next fetch offset. | ||
| */ | ||
| private final TreeSet<Long> gapsAfterInitialization; |
There was a problem hiding this comment.
Is TreeSet necessary (lg(n) time data structure).
You are assured that the readState reponse will always be sorted on the intervals - the order is
firstOffset, lastOffset, deliveryCount, deliveryState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug -> there are times during share partition initialization, where the persister read state response contains batches, eg -
startOffset = 10, stateBatches = {{15, 20}, {30, 40}}
These gaps could natural gaps, but could also be batches which were fetched before but were not acknowledged. In that case, these records must be made available again for fetch.
This PR introduces another class variable,
gapsAfterInitialization, which stores the first offset of all these gaps in the read state response. ThenextFetchOffsetmethod then consider these gaps as well while finding the next offset to fetch from.