Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18634: Fix ELR metadata version issues #18680

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-18634: Fix ELR metadata version issues #18680

wants to merge 2 commits into from
+89 −16

Conversation

CalvinConfluent
Copy link
Contributor

  • Clean up the places that should not use MV to determine ELR is enabled

  • Mark 4.0IV1 stable.

https://issues.apache.org/jira/browse/KAFKA-18634

@github-actions github-actions bot added triage PRs from the community core Kafka Broker kraft labels Jan 23, 2025
CalvinConfluent
CalvinConfluent commented Jan 23, 2025
View reviewed changes
Copy link
Contributor Author

@CalvinConfluent CalvinConfluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes are due to the PartitionRecord needing the feature version to determine if it should keep the ELR related fields. So I added the finalized features to the ImageWriterOptions.

@github-actions github-actions bot removed the triage PRs from the community label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Kafka Broker kraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CalvinConfluent