-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RANGER-5080: Add docker support for MS SQL Server #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
reviewed
Jan 24, 2025
mneethiraj
reviewed
Jan 24, 2025
mneethiraj
approved these changes
Jan 24, 2025
I'll revert changes in maven.yml added to perform testing soon. |
kumaab
added
testing complete
PR testing is complete
and removed
testing pending
labels
Jan 24, 2025
mneethiraj
approved these changes
Jan 25, 2025
kumaab
added a commit
that referenced
this pull request
Jan 25, 2025
(cherry picked from commit bc4c95c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding support for MS SQL Server - ranger database in docker.
2019-latest
is the version used from dockerhub: https://hub.docker.com/r/microsoft/mssql-serverThere were issues with
2022-latest
image with missing libraries and issues in bringing the SQL server up, so using the2019-latest
version in this PR.SSL is enabled in the image by default, the PR uses self-signed certs (and not certs from a CA) to setup db for
ranger
andranger-kms
services .How was this patch tested?
The patch required testing on
amd64
compatible architecture.CI step:
View sql server logs
shows database container logs after startup, no errors are seen.ranger-sqlserver
container is in running state in the logs.ranger-kms
completed installation withranger-sqlserver
successfully.