RATIS-2164. LeakDetector has a race condition. #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@duongkame , @133tosakarin , @OneSizeFitsQuorum , @adoroszlai , please take a look. |
|
The failures are expected since it needs the other fixes described in #1156 |
133tosakarin
approved these changes
Oct 8, 2024
|
@OneSizeFitsQuorum , @adoroszlai , we need a committer review approval for this. With this and RATIS-2173, the tests will be much easier to pass (although there may be still some undiscovered bugs.) |
adoroszlai
approved these changes
Oct 16, 2024
|
@adoroszlai , thanks a lot for reviewing this! Although the test failures are unrelated, let's rerun them one more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RATIS-2164
This is mainly fixing the first two problem mentioned in #1156
LeakDetector: asserted allLeaks is non-empty but printed "allLeaks.size = 0"retain(). Without callingretain()at all, it is not a leak.SimpleTracingandAdvancedTracing: the methods should be synchronized.AdvancedTracingshould have a single track list instead of two lists:retainsTracesandreleaseTraces.