Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typescript #3084

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cameron-martin
Copy link

Client: nodejs

Typescript was on a really old version, and upgrading this is necessary for future changes. Upgrading this required upgrading @types/node and commander, since the old versions of these are not compatible with the newer version of typescript.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@cameron-martin cameron-martin force-pushed the update-typescript branch 2 times, most recently from c68a18e to 086dfbe Compare January 8, 2025 15:42
@fishy fishy added typescript javascript Pull requests that update Javascript code labels Jan 8, 2025
Client: nodejs

Typescript was on a really old version, and upgrading this is necessary for future changes. Upgrading this required upgrading `@types/node` and `commander`, since the old versions of these are not compatible with the newer version of typescript.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants