chore: Removing unused files & components #38832

ankitakinger · 2025-01-24T07:53:57Z

Description

Removing unused files & components from the codebase.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12948390264
Commit: 57771b0
Cypress dashboard.
Tags: @tag.All
Spec:

Fri, 24 Jan 2025 12:07:41 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Removals
- Deleted multiple components related to entity explorer, pages, and onboarding
- Removed onboarding-related actions, reducers, and saga handlers
- Eliminated signposting step tracking and management functionality
Refactoring
- Updated import paths for various components
- Restructured file organization in the editor and explorer sections
Impact
- Significant changes to the user interface and onboarding experience
- Simplified state management for explorer and onboarding features

coderabbitai · 2025-01-24T07:54:06Z

Walkthrough

This pull request involves a comprehensive cleanup of unused components, primarily focusing on removing legacy onboarding and explorer-related React components. The changes target components and associated utilities in the editor and onboarding sections, systematically eliminating code that is no longer required after recent architectural updates. The modifications span multiple files across the client-side application, removing Redux actions, reducers, and React components related to first-time user onboarding and entity exploration.

Changes

File Path	Change Summary
`app/client/src/pages/Editor/Explorer/`	Removed multiple components: `EntityExplorer.tsx`, `Pages/index.tsx`, `index.tsx`, `Widgets/WidgetGroup.tsx`
`app/client/src/pages/Editor/FirstTimeUserOnboarding/`	Removed `Statusbar.test.tsx`, `Statusbar.tsx`, `constants.ts`
`app/client/src/actions/onboardingActions.ts`	Deleted `signpostingStepUpdateInit` and `signpostingStepUpdate` functions
`app/client/src/reducers/`	Removed action handlers in `uiReducers/onBoardingReducer.ts` and `uiReducers/appSettingsPaneReducer.ts`
`app/client/src/sagas/`	Removed `setSignpostingStepStateSaga` from `OnboardingSagas.ts`
Import Updates	Modified import paths in various files to reflect new component locations

Assessment against linked issues

Objective	Addressed	Explanation
Remove unused old components	✅
Remove corresponding utils, hooks, constants	✅

Possibly related PRs

feat: ADS Entity Item #38442: Addition of Entity Item component
chore: Adding Group component in ADS Templates #38512: Addition of Group component
chore: decouple editor components #37102: Decoupling of editor components

Suggested Reviewers

ApekshaBhosale
sagar-qa007
jsartisan
hetunandu

Poem

Code cleanup, a digital dance,
Removing relics with each glance,
Unused components fade away,
Streamlined paths now lead the way! 🧹✨
Refactoring's sweet, elegant art! 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

hetunandu · 2025-01-24T08:52:57Z

app/client/src/pages/Editor/Explorer/Common/EntityExplorerResizeHandler.tsx

We can remove this file itself because it is not resizable

Its being used in Package editor as of now. Hence I'd removed but then had to add it back.

app/client/src/pages/Editor/Explorer/EntityExplorer.test.tsx

hetunandu · 2025-01-24T08:55:16Z

app/client/src/sagas/OnboardingSagas.ts

Are we using any other onboarding functionality from here?
If not, we can delete these as well

yup others seem to be getting used

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

app/client/src/pages/Editor/IDE/EditorPane/UI/List.test.tsx (2)

88-88: Validate usage of new prop.
Passing setFocusSearchInput is helpful for test verification, but consider adding a test checking if the search input actually focuses.

174-174: Repeated rendering approach.
Same usage pattern; no issues but consider a helper function to avoid duplication in future.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2176f3 and 57771b0.

📒 Files selected for processing (1)

app/client/src/pages/Editor/IDE/EditorPane/UI/List.test.tsx (7 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: perform-test / client-build / client-build
GitHub Check: perform-test / rts-build / build
GitHub Check: perform-test / server-build / server-unit-tests
GitHub Check: client-unit-tests / client-unit-tests
GitHub Check: client-lint / client-lint
GitHub Check: client-build / client-build
GitHub Check: client-prettier / prettier-check
GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies

🔇 Additional comments (8)

app/client/src/pages/Editor/IDE/EditorPane/UI/List.test.tsx (8)

16-16: Good import addition.
Imports the new ListWidgets component, aligning with the component replacement focus of this PR.

54-54: Appropriate mocking approach.
Using jest.fn() for setFocusSearchInput is a convenient way to verify function calls.

55-55: No change needed.
This is simply a blank line and doesn't affect functionality.

56-56: Clearer test description.
Renaming the test suite to "Widget List in Explorer tests" provides more context.

94-94: Dynamic label usage.
Using children[0].widgetName for the widget label is more robust than a static string. Good move!

133-133: Consistent component usage.
Reusing <ListWidgets setFocusSearchInput={setFocusSearchInput} /> maintains consistency across tests.

231-231: Consistency in multi-selection tests.
Again, consistent approach for verifying multi-select behavior. Looks good.

325-325: Alignment with container tests.
The usage is consistent in container widget tests as well; no concerns here.

removing unused files & components

368d4c6

removing unused functions and constants

e85d5e9

ankitakinger requested a review from ayushpahwa as a code owner January 24, 2025 08:13

ankitakinger added 2 commits January 24, 2025 13:57

removing unused hoo

b36745d

adding back components still being used in EE

a2176f3

ankitakinger changed the title ~~removing unused files & components~~ chore: Removing unused files & components Jan 24, 2025

github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo labels Jan 24, 2025

ankitakinger requested a review from hetunandu January 24, 2025 08:46

hetunandu reviewed Jan 24, 2025

View reviewed changes

ankitakinger added the ok-to-test Required label for CI label Jan 24, 2025

renaming a test file and moving it to another folder

57771b0

coderabbitai bot reviewed Jan 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Removing unused files & components #38832

chore: Removing unused files & components #38832

ankitakinger commented Jan 24, 2025 •

edited by github-actions bot

Loading

coderabbitai bot commented Jan 24, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

hetunandu Jan 24, 2025

ankitakinger Jan 24, 2025 •

edited

Loading

hetunandu Jan 24, 2025

ankitakinger Jan 24, 2025

coderabbitai bot left a comment

chore: Removing unused files & components #38832

Are you sure you want to change the base?

chore: Removing unused files & components #38832

Conversation

ankitakinger commented Jan 24, 2025 • edited by github-actions bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

coderabbitai bot commented Jan 24, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested Reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

hetunandu Jan 24, 2025

Choose a reason for hiding this comment

ankitakinger Jan 24, 2025 • edited Loading

Choose a reason for hiding this comment

hetunandu Jan 24, 2025

Choose a reason for hiding this comment

ankitakinger Jan 24, 2025

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

ankitakinger commented Jan 24, 2025 •

edited by github-actions bot

Loading

coderabbitai bot commented Jan 24, 2025 •

edited

Loading

ankitakinger Jan 24, 2025 •

edited

Loading