Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removing unused files & components #38832

Open
wants to merge 5 commits into
base: release
Choose a base branch
from
Open

chore: Removing unused files & components #38832

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
368d4c6
removing unused files & components
ankitakinger Jan 23, 2025
e85d5e9
removing unused functions and constants
ankitakinger Jan 24, 2025
b36745d
removing unused hoo
ankitakinger Jan 24, 2025
a2176f3
adding back components still being used in EE
ankitakinger Jan 24, 2025
57771b0
renaming a test file and moving it to another folder
ankitakinger Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions app/client/src/actions/onboardingActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { ReduxActionTypes } from "ee/constants/ReduxActionConstants";
import type { SIGNPOSTING_STEP } from "pages/Editor/FirstTimeUserOnboarding/Utils";

export const toggleInOnboardingWidgetSelection = (payload: boolean) => {
return {
Expand Down Expand Up @@ -58,27 +57,6 @@ export const signpostingMarkAllRead = () => {
};
};

export const signpostingStepUpdateInit = (payload: {
step: SIGNPOSTING_STEP;
completed: boolean;
}) => {
return {
type: ReduxActionTypes.SIGNPOSTING_STEP_UPDATE_INIT,
payload,
};
};

export const signpostingStepUpdate = (payload: {
step: SIGNPOSTING_STEP;
completed: boolean;
read?: boolean;
}) => {
return {
type: ReduxActionTypes.SIGNPOSTING_STEP_UPDATE,
payload,
};
};

export const showSignpostingTooltip = (payload: boolean) => {
return {
type: ReduxActionTypes.SIGNPOSTING_SHOW_TOOLTIP,
Expand Down
4 changes: 0 additions & 4 deletions app/client/src/ce/constants/ReduxActionConstants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,6 @@ const OnboardingActionTypes = {
UNDO_END_FIRST_TIME_USER_ONBOARDING: "UNDO_END_FIRST_TIME_USER_ONBOARDING",
SET_SIGNPOSTING_OVERLAY: "SET_SIGNPOSTING_OVERLAY",
SIGNPOSTING_MARK_ALL_READ: "SIGNPOSTING_MARK_ALL_READ",
SIGNPOSTING_STEP_UPDATE_INIT: "SIGNPOSTING_STEP_UPDATE_INIT",
SIGNPOSTING_STEP_UPDATE: "SIGNPOSTING_STEP_UPDATE",
SIGNPOSTING_SHOW_TOOLTIP: "SIGNPOSTING_SHOW_TOOLTIP",
SHOW_ANONYMOUS_DATA_POPUP: "SHOW_ANONYMOUS_DATA_POPUP",
FIRST_TIME_USER_ONBOARDING_INIT: "FIRST_TIME_USER_ONBOARDING_INIT",
Expand Down Expand Up @@ -1190,8 +1188,6 @@ const AppThemeActionErrorTypes = {
};

const AppSettingsActionTypes = {
OPEN_APP_SETTINGS_PANE: "OPEN_APP_SETTINGS_PANE",
CLOSE_APP_SETTINGS_PANE: "CLOSE_APP_SETTINGS_PANE",
UPDATE_APP_SETTINGS_PANE_SELECTED_TAB:
"UPDATE_APP_SETTINGS_PANE_SELECTED_TAB",
};
Expand Down
23 changes: 0 additions & 23 deletions app/client/src/ce/reducers/uiReducers/explorerReducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,29 +196,6 @@ export const handlers = {
active: action.payload,
};
},
[ReduxActionTypes.OPEN_APP_SETTINGS_PANE]: (
state: ExplorerReduxState,
): ExplorerReduxState => {
return {
...state,
pinnedState:
state.pinnedState === ExplorerPinnedState.PINNED
? ExplorerPinnedState.HIDDEN
: state.pinnedState,
active: false,
};
},
[ReduxActionTypes.CLOSE_APP_SETTINGS_PANE]: (
state: ExplorerReduxState,
): ExplorerReduxState => {
return {
...state,
pinnedState:
state.pinnedState === ExplorerPinnedState.HIDDEN
? ExplorerPinnedState.PINNED
: state.pinnedState,
};
},
};

const explorerReducer = createReducer(initialState, handlers);
Expand Down
10 changes: 6 additions & 4 deletions app/client/src/pages/Editor/Explorer/Common/EntityExplorerResizeHandler.tsx
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this file itself because it is not resizable

Copy link
Contributor Author

@ankitakinger ankitakinger Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its being used in Package editor as of now. Hence I'd removed but then had to add it back.

Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import { tailwindLayers } from "constants/Layers";
import React from "react";
import styled from "styled-components";
import type { CallbackResponseType } from "utils/hooks/useResize";
import useResize, { DIRECTION } from "utils/hooks/useResize";
import useResize, {
DIRECTION,
type CallbackResponseType,
} from "utils/hooks/useResize";

const ResizeHandler = styled.div`
&:hover {
Expand Down Expand Up @@ -33,8 +35,8 @@ export const EntityExplorerResizeHandler = ({
onMouseDown={() => setMouseDown(true)}
>
<ResizeHandler
className={`w-full h-1 bg-transparent hover:bg-transparent transform transition
${mouseDown ? "" : ""}
className={`w-full h-1 bg-transparent hover:bg-transparent transform transition
${mouseDown ? "" : ""}
`}
/>
</div>
Expand Down
1 change: 0 additions & 1 deletion app/client/src/pages/Editor/Explorer/Common/components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import styled from "styled-components";
import Entity, { EntityClassNames } from "../Entity";

export const ENTITY_HEIGHT = 36;
export const MIN_PAGES_HEIGHT = 60;

export const RelativeContainer = styled.div`
Expand Down
Loading
Loading