-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IGNORE] : just for DP #38549
base: release
Are you sure you want to change the base?
[IGNORE] : just for DP #38549
Conversation
WalkthroughThis pull request updates the Changes
Possibly related PRs
Suggested labels
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12684318856. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (2)
CODEOWNERS (2)
Line range hint
58-93
: Resolve ownership conflicts with the App viewers pod.There are overlapping ownership assignments that need to be resolved:
app/client/src/components/propertyControls/*
is assigned to both @appsmithorg/widgets-blocks and @appsmithorg/anvil-teamapp/client/src/widgets/*
is assigned to @appsmithorg/widgets-blocks but specific widget files are assigned to @appsmithorg/anvil-teamThis could lead to confusion about who has the final review authority.
Consider either:
- Removing duplicate assignments, or
- Making the ownership more specific by using more precise path patterns
Resolve ownership conflicts in CODEOWNERS patterns
The globstar patterns are valid and match existing files, but there are ownership conflicts:
app/client/src/components/propertyControls/*
is assigned to both @appsmithorg/widgets-blocks and @appsmithorg/anvil-teamapp/client/src/widgets/*
(@appsmithorg/widgets-blocks) conflicts with specific widget files owned by @appsmithorg/anvil-team🔗 Analysis chain
Line range hint
58-93
: Verify the globstar patterns.The path patterns follow the correct syntax. However, let's verify that they match the intended files:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the new path patterns match existing files # and don't conflict with other teams' ownership. echo "Checking if paths exist and showing potential conflicts..." # Check if the paths exist for pattern in \ "app/client/generators/" \ "app/client/src/actions/canvasSelectionActions.ts" \ "app/client/src/actions/reflowActions.ts" \ "app/client/src/actions/widgetSelectionActions.ts" \ "app/client/src/components/propertyControls/" \ "app/client/src/layoutSystems/anvil/" \ "app/client/src/pages/Editor/Canvas.tsx" \ "app/client/src/pages/Editor/CanvasLayoutConversion/" \ "app/client/src/pages/Editor/PropertyPane/" \ "app/client/src/pages/Editor/WidgetsEditor/" \ "app/client/src/widgets/BaseWidget.tsx" \ "app/client/src/widgets/CanvasWidget.tsx"; do echo "Checking: $pattern" fd "$pattern" done # Show potential conflicts by checking if files match multiple patterns echo -e "\nChecking for ownership conflicts..." for file in $(fd -t f 'app/client/src/(components/propertyControls|widgets)/'); do echo "Checking ownership for: $file" rg -l "^$file\s+@" CODEOWNERS || true doneLength of output: 11377
Script:
#!/bin/bash # Description: Verify paths with correct fd syntax and check conflicts echo "Checking directories..." for dir in \ "app/client/src/components/propertyControls" \ "app/client/src/layoutSystems/anvil" \ "app/client/src/pages/Editor/CanvasLayoutConversion" \ "app/client/src/pages/Editor/PropertyPane" \ "app/client/src/pages/Editor/WidgetsEditor"; do echo "Directory: $dir" fd --full-path "$dir$" || echo "Not found: $dir" done echo -e "\nChecking specific files..." for file in \ "canvasSelectionActions.ts" \ "reflowActions.ts" \ "widgetSelectionActions.ts" \ "Canvas.tsx" \ "BaseWidget.tsx" \ "CanvasWidget.tsx"; do echo "File: $file" fd "$file$" done echo -e "\nChecking for ownership conflicts in CODEOWNERS..." rg "^app/client/src/(components/propertyControls|widgets).*\s+@" CODEOWNERSLength of output: 5419
🧹 Nitpick comments (1)
CODEOWNERS (1)
55-55
: Remove unnecessary empty line.This empty line serves no purpose and should be removed for better readability.
Deploy-Preview-URL: https://ce-38549.dp.appsmith.com |
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Number
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit