Feat: update deploy script #33
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gin repo address from the env vars
…ommons config or the env file
novaknole
reviewed
Jan 25, 2025
| let pluginRepoFactoryAddress; | ||
| let subdomainRegistrar; | ||
| if ( | ||
| process.env.PLUGIN_REPO_FACTORY_ADDRESS && |
There was a problem hiding this comment.
I think instead of 2 lines, which is still not trustful, it's better to directly check if process.env.PLUGIN_REPO_FACTORY_ADDRESS is a type of address. This will eliminate 2 checks.
These 2 checks are not trustworthy because if i set PLUGIN_REPO_FACTORY_ADDRESS=blax, this will still work which is wrong.
novaknole
reviewed
Jan 25, 2025
| const subdomain = | ||
| subdomainRegistrar !== ethers.constants.AddressZero | ||
| ? PLUGIN_REPO_ENS_SUBDOMAIN_NAME | ||
| : 'empty'; // todo set to empty when is possible |
There was a problem hiding this comment.
why empty ? even if you make it equal to '', it will still work. no ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and be sure you follow the contributions rules we do provide here
Task ID: OS-?
Type of change
See the framework lifecylce in
packages/contracts/docs/framework-lifecycleto decide what kind of change this pull request is.Checklist:
CHANGELOG.mdfile in the root folder.DEPLOYMENT_CHECKLISTfile in the root folder.UPDATE_CHECKLISTfile in the root folder.