Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Pod Security Context: Volumes aren't required in >= v3.3 and runAsNonRoot #14072

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

paulcwatts
Copy link

@paulcwatts paulcwatts commented Jan 10, 2025

Motivation

A note regarding volumes being required for runAsNonRoot took me down an incorrect path before I saw that was unnecessary in newer versions. I'm hoping this will save other developers a couple of hours of going down the same path.

Modifications

Based on the PR discussion, I removed the note since v3.3 is no longer supported.

@paulcwatts paulcwatts force-pushed the pod-security-doc-fix branch from f9582e3 to 08d7df9 Compare January 10, 2025 20:40
I'm hoping this will save other developers a couple of hours of going down an unnecessary path.

Signed-off-by: Paul Watts <[email protected]>
@paulcwatts paulcwatts force-pushed the pod-security-doc-fix branch from 08d7df9 to e8e5d1b Compare January 10, 2025 20:43
@blkperl blkperl added the area/docs Incorrect, missing, or mistakes in docs label Jan 11, 2025
Copy link
Contributor

@MasonM MasonM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! One small comment, but otherwise LGTM

docs/workflow-pod-security-context.md Outdated Show resolved Hide resolved
Code review feedback

Co-authored-by: Mason Malone <[email protected]>
Signed-off-by: Paul Watts <[email protected]>
docs/workflow-pod-security-context.md Outdated Show resolved Hide resolved
Based on the PR conversation: since 3.3 is no longer supported, we can completely remove this note.

Signed-off-by: Paul Watts <[email protected]>
@paulcwatts paulcwatts requested a review from tczhao January 25, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants