Make --no-default-groups work with --all-groups
#10891
Conversation
crates/uv-cli/src/lib.rs
Outdated
| #[arg(long, conflicts_with_all = ["only_group", "all_groups"])] | ||
| pub group: Vec<GroupName>, |
There was a problem hiding this comment.
I don't think these need to conflict, they're just redundant? (--group foo --all-groups)
| #[arg(long, conflicts_with_all = ["no_group", "only_group"])] | ||
| #[arg(long, conflicts_with_all = ["only_group"])] | ||
| pub no_default_groups: bool, |
There was a problem hiding this comment.
👍 yeah this was wrong
Similarly, I think --only-group is just redundant? --only-group foo --no-default-groups doesn't need to error.
There was a problem hiding this comment.
The current flag conflicts in groups are inconsistent (for example, --only-dev should conflict with --group, but it doesn't). I'd like to address these in a separate PR.
crates/uv-cli/src/lib.rs
Outdated
| #[arg(long, conflicts_with_all = ["group", "no_default_groups", "all_groups"])] | ||
| pub only_group: Vec<GroupName>, |
There was a problem hiding this comment.
Agree this should conflict with --all-groups
j178
force-pushed
the
groups-cli
branch
2 times, most recently
from
38c263e to
26f70b0
Compare
j178
changed the title
--no-default-groups works with --all-groups--no-default-groups work with --all-groups
| DevMode::Exclude => false, | ||
| DevMode::Include | DevMode::Only => group == &*DEV_DEPENDENCIES, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This method is not used anywhere.
| } | ||
| } | ||
|
|
||
| /// Returns `true` if the specification includes the given group. | ||
| pub fn contains(&self, group: &GroupName) -> bool { | ||
| pub fn contains(&self, group: &GroupName, is_default_group: bool) -> bool { |
There was a problem hiding this comment.
The is_default_group: bool argument is not ideal, but it seems to be the simplest solution I could come up with.
Summary
Closes #10890