-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added first workflow #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KhudaDad414 I left some comments. Looks good so far, just minor stuff
long term, once these calls are expensive we at least have a custom code we can influence and setup a kind of persistence, where we share information about contributors and can check with the API if user is on the list or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just think that this workflow should be added here and we should not add a new file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff mate, great contribution as usual 🚀
Now merge and let us see how it works in action 🤞🏼 😄
Description
issues
Graphql query.pullRequests
query, we are using thesearch
query for PRs.Related issue(s)
Resolves Remove
welcome
workflow and replace with something custom #73