-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_objects_of_interest_marker_interface): porting from universe to core #168
base: main
Are you sure you want to change the base?
Conversation
…verse to core, autoware_objects_of_interest_marker_interface, add this package to core repo and replace universe_utils dependency with autoware_utils dependency: v0.0 Signed-off-by: liuXinGangChina <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…verse to core, autoware_objects_of_interest_marker_interface, fix readme spell issue: v0.1 Signed-off-by: liuXinGangChina <[email protected]>
dc55091
to
a145d20
Compare
…verse to core, autoware_objects_of_interest_marker_interface, update due to the function name change of autoware_utils: v0.2 Signed-off-by: liuXinGangChina <[email protected]>
5f363bf
to
211b164
Compare
The modification seems okay, but this must be merged after autowarefoundation/autoware_utils#23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding autoware_utils
to build_depends.repos
will make the CI pass. Other than that, LGTM.
@liuXinGangChina #149 will take some time to merge, so we would like to merge this PR first since it has no external dependencies.
|
We are porting autoware_objects_of_interest_marker_interface to autoware.core, and this PR add the package to core
Description
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.