Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_objects_of_interest_marker_interface): porting from universe to core #168

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

liuXinGangChina
Copy link
Contributor

@liuXinGangChina liuXinGangChina commented Jan 15, 2025

We are porting autoware_objects_of_interest_marker_interface to autoware.core, and this PR add the package to core

Description

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…verse to core, autoware_objects_of_interest_marker_interface, add this package to core repo and replace universe_utils dependency with autoware_utils dependency: v0.0

Signed-off-by: liuXinGangChina <[email protected]>
Copy link

github-actions bot commented Jan 15, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

…verse to core, autoware_objects_of_interest_marker_interface, fix readme spell issue: v0.1

Signed-off-by: liuXinGangChina <[email protected]>
@liuXinGangChina liuXinGangChina force-pushed the obj-marker-interface-migration branch from dc55091 to a145d20 Compare January 15, 2025 10:03
…verse to core, autoware_objects_of_interest_marker_interface, update due to the function name change of autoware_utils: v0.2

Signed-off-by: liuXinGangChina <[email protected]>
@liuXinGangChina liuXinGangChina force-pushed the obj-marker-interface-migration branch from 5f363bf to 211b164 Compare January 16, 2025 02:53
@mitsudome-r
Copy link
Member

The modification seems okay, but this must be merged after autowarefoundation/autoware_utils#23

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding autoware_utils to build_depends.repos will make the CI pass. Other than that, LGTM.

@liuXinGangChina
Copy link
Contributor Author

liuXinGangChina commented Jan 24, 2025

I think adding autoware_utils to build_depends.repos will make the CI pass. Other than that, LGTM.

That‘s right Kondo san @youtalk ,and we do that in this pr
once pr-149 merged we will rebase this pr for merging

Best regrads

心刚

@youtalk
Copy link
Member

youtalk commented Jan 29, 2025

@liuXinGangChina #149 will take some time to merge, so we would like to merge this PR first since it has no external dependencies.

#168 (review)

I think adding autoware_utils to build_depends.repos will make the CI pass. Other than that, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants