Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_planning_evaluator): add resampled_relative_angle metrics #10020

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Kazunori-Nakajima
Copy link
Contributor

Description

Added metrics to look at angular differences in trajectory points.
This metric enables detection of severe route misalignments, such as bends of more than 90° in local trajectory.

Related links

Parent Issue:

  • Link

How was this PR tested?

simplescreenrecorder-2025-01-27_09.08.46.mp4

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) label Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Comment on lines 92 to 96
// Resample trajctory points
std::vector<TrajectoryPoint> resample_traj_points{};
for (size_t idx = 0; idx < traj.points.size(); idx = idx + 3) {
resample_traj_points.push_back(traj.points.at(idx));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary for calculation costs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for comment!
It seems to not necessary. This processing time is at most 0.5 ms.
I deleted this code -> 1b29489

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
0.5ms seems not so problem

( for reduce proccesing time more: https://star4.slack.com/archives/C03QW0GU6P7/p1737942266253849?thread_ts=1737937464.395459&cid=C03QW0GU6P7 )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
I fixed it.

default.mp4

Comment on lines 87 to 90
// We need at least three points to compute relative angle
if (traj.points.size() < 2) {
return stat;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we can delete this lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted!

@kosuke55
Copy link
Contributor

  • rename metrics name to resampled_relative_angle
  • fix ci check

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 27, 2025
@kosuke55 kosuke55 changed the title feat(autoware_planning_evaluator): add new large_relative_angle metrics feat(autoware_planning_evaluator): add resampled_relative_angle metrics Jan 27, 2025
@kosuke55 kosuke55 force-pushed the feat/planning_evaluator/add_large_relative_angle branch from 98463cc to 9246146 Compare January 27, 2025 14:14
@kosuke55
Copy link
Contributor

@Kazunori-Nakajima
ci unit test fails, it seems that you need to update test code for using vehicle_info in it.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

4 participants