-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_planning_evaluator): add resampled_relative_angle metrics #10020
base: main
Are you sure you want to change the base?
feat(autoware_planning_evaluator): add resampled_relative_angle metrics #10020
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
// Resample trajctory points | ||
std::vector<TrajectoryPoint> resample_traj_points{}; | ||
for (size_t idx = 0; idx < traj.points.size(); idx = idx + 3) { | ||
resample_traj_points.push_back(traj.points.at(idx)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary for calculation costs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for comment!
It seems to not necessary. This processing time is at most 0.5 ms.
I deleted this code -> 1b29489
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
0.5ms seems not so problem
( for reduce proccesing time more: https://star4.slack.com/archives/C03QW0GU6P7/p1737942266253849?thread_ts=1737937464.395459&cid=C03QW0GU6P7 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
I fixed it.
default.mp4
// We need at least three points to compute relative angle | ||
if (traj.points.size() < 2) { | ||
return stat; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now we can delete this lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted!
|
Signed-off-by: Kasunori-Nakajima <[email protected]>
Signed-off-by: Kasunori-Nakajima <[email protected]>
Signed-off-by: Kasunori-Nakajima <[email protected]>
Signed-off-by: Kasunori-Nakajima <[email protected]>
Signed-off-by: Kasunori-Nakajima <[email protected]>
98463cc
to
9246146
Compare
@Kazunori-Nakajima |
Description
Added metrics to look at angular differences in trajectory points.
This metric enables detection of severe route misalignments, such as bends of more than 90° in local trajectory.
Related links
Parent Issue:
How was this PR tested?
simplescreenrecorder-2025-01-27_09.08.46.mp4
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.