Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_modules): add node test #9790

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 25, 2024

Description

Continuing the following PR, this PR added a node test to each package in the behavior_velocity_planner.
Please see the description of the following PR for the details.
#9760

Additionally, due to the current include directory's structure (include/autoware/<package-name>), it is impossible to

  • generate messages/sevices
  • make the implementation as a library, and another package will include it
    at the same time since we got an error of failing to find the library.
    Note: This is because the include directories for the implementation library and messages/services are different.

That's why this PR removes the service generation, and we decided to use the following external service in the autoware_internal_debug_msgs package.
https://github.com/autowarefoundation/autoware_internal_msgs/blob/main/autoware_internal_debug_msgs/srv/String.srv

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 25, 2024
@takayuki5168 takayuki5168 force-pushed the feat/behavior-velocity-packages-node-test branch from dab0398 to c5890d0 Compare December 25, 2024 16:02
Copy link

github-actions bot commented Dec 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 force-pushed the feat/behavior-velocity-packages-node-test branch from c5890d0 to ec82355 Compare December 26, 2024 07:06
@takayuki5168 takayuki5168 marked this pull request as ready for review December 26, 2024 07:15
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 26, 2024
@takayuki5168 takayuki5168 changed the title feat(behavior_velocity_xxx_module): add node test feat(behavior_velocity_modules): add node test Dec 26, 2024
@takayuki5168 takayuki5168 force-pushed the feat/behavior-velocity-packages-node-test branch from 0d1cd9b to db7dbe9 Compare December 26, 2024 07:44
@takayuki5168 takayuki5168 force-pushed the feat/behavior-velocity-packages-node-test branch 2 times, most recently from 15844fd to 0f327a8 Compare December 27, 2024 01:25
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.71%. Comparing base (a32cae1) to head (d9a331d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...er/autoware_behavior_velocity_planner/src/node.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9790      +/-   ##
==========================================
+ Coverage   28.77%   29.71%   +0.94%     
==========================================
  Files        1457     1462       +5     
  Lines      109221   109273      +52     
  Branches    42566    42767     +201     
==========================================
+ Hits        31428    32471    +1043     
+ Misses      74714    73680    -1034     
- Partials     3079     3122      +43     
Flag Coverage Δ *Carryforward flag
differential 18.59% <50.00%> (?)
total 28.77% <ø> (-0.01%) ⬇️ Carriedforward from a32cae1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 force-pushed the feat/behavior-velocity-packages-node-test branch from b0f521f to d9a331d Compare January 6, 2025 01:15
@takayuki5168 takayuki5168 merged commit 176e2e3 into autowarefoundation:main Jan 6, 2025
34 checks passed
@takayuki5168 takayuki5168 deleted the feat/behavior-velocity-packages-node-test branch January 6, 2025 02:25
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 6, 2025
* feat(behavior_velocity_crosswalk): add node test

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* feat(behavior_velocity_xxx_module): add node test

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* change directory tests -> test

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants