Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop convert windows path to posix style #7826

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

y-stm
Copy link

@y-stm y-stm commented Jan 9, 2025

Which issue(s) does this change fix?

#7807

Why is this change necessary?

This change make enable to work sam local invoke or sam local start-api with some container management tools other than Docker Desktop in Windows (such as Rancher Desktop and Podman Desktop.)

How does it address the issue?

The cause of disturbing other tools is converting windows path to posix style when binds host directory to container.
(that converts 'C:\path\to\built\Function' to '/c/path/to/built/Function')
However, this conversion suits only for Docker Toolkit and other docker engines don't handle correctly unix-style-path as host directory path.
Removing converting function and uses will fix this issue.

What side effects does this change have?

This change may affect only in windows. Because removed function works as if identity function when given path is already unix style.
After this PR, sam cli will lose Dropbox Toolbox support.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@y-stm y-stm requested a review from a team as a code owner January 9, 2025 14:54
@github-actions github-actions bot added area/local/start-api sam local start-api command area/local/invoke sam local invoke command area/local/start-invoke pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jan 9, 2025
@seshubaws
Copy link
Contributor

Hi @y-stm, thank you for raising this PR! I see some tests are failing due to linting issues, can you please update this PR to fix them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants