Stop convert windows path to posix style #7826
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#7807
Why is this change necessary?
This change make enable to work
sam local invoke
orsam local start-api
with some container management tools other than Docker Desktop in Windows (such as Rancher Desktop and Podman Desktop.)How does it address the issue?
The cause of disturbing other tools is converting windows path to posix style when binds host directory to container.
(that converts 'C:\path\to\built\Function' to '/c/path/to/built/Function')
However, this conversion suits only for Docker Toolkit and other docker engines don't handle correctly unix-style-path as host directory path.
Removing converting function and uses will fix this issue.
What side effects does this change have?
This change may affect only in windows. Because removed function works as if identity function when given path is already unix style.
After this PR, sam cli will lose Dropbox Toolbox support.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.