feat(amazonq): support Java 21 #5226
Open
+80
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhasani23
commented
Jan 21, 2025
| @@ -308,6 +309,8 @@ class CodeModernizerSession( | |||
| } | |||
|
|
|||
| private fun startJob(uploadId: String): StartTransformationResponse { | |||
| notifyStickyInfo("sourceLanguage", sessionContext.sourceJavaVersion.name.toTransformationLanguage().toString()) | |||
| notifyStickyInfo("targetLanguage", sessionContext.targetJavaVersion.name.toTransformationLanguage().toString()) | |||
dhasani23
commented
Jan 21, 2025
| val sourceVersion = sourceJdk.toString() | ||
|
|
||
| notifyStickyInfo("sourceJdk is", sourceJdk.toString()) | ||
| notifyStickyInfo("targetVersion is", targetVersion) |
dhasani23
commented
Jan 21, 2025
| ) | ||
|
|
||
| notifyStickyInfo("customerSelection is", selection.toString()) |
| @@ -66,7 +66,8 @@ const val DOWNLOAD_PROXY_WILDCARD_ERROR: String = "Dangling meta character '*' n | |||
| const val DOWNLOAD_SSL_HANDSHAKE_ERROR: String = "Unable to execute HTTP request: javax.net.ssl.SSLHandshakeException" | |||
| const val INVALID_ARTIFACT_ERROR: String = "Invalid artifact" | |||
| val patchDescriptions = mapOf( | |||
| "Prepare minimal upgrade to Java 17" to "This diff patch covers the set of upgrades for Springboot, JUnit, and PowerMockito frameworks.", | |||
| "Prepare minimal upgrade to Java 17" to "This diff patch covers the set of upgrades for Springboot, JUnit, and PowerMockito frameworks in Java 17.", | |||
| "Prepare minimal upgrade to Java 21" to "This diff patch covers the set of upgrades for Springboot, JUnit, and PowerMockito frameworks in Java 21.", | |||
There was a problem hiding this comment.
Same with VSCode, I haven't looked at the closures for java 21 (I can look), but assuming they make the same corresponding upgrades as the first patch for java 17
| CodeTransformChatMessageContent( | ||
| message = message("codemodernizer.chat.message.one_or_multiple_diffs"), | ||
| message = message("codemodernizer.chat.message.one_or_multiple_diffs", version.substring(4)), // extract "17" / "21" from "JDK_17" / "JDK_21" |
There was a problem hiding this comment.
Just wondering why we can't just have strings for "17" and "21", is it just to make use of constants we already have and not unnecessarily introduce new ones?
There was a problem hiding this comment.
Yeah the built-in JavaSdkVersion class we use represents Java 17 as "JDK_17" and Java 21 as "JDK_21"
| @@ -620,7 +620,8 @@ codemodernizer.chat.message.button.view_diff=View diff | |||
| codemodernizer.chat.message.button.view_failure_build_log=View Failure Build Log | |||
| codemodernizer.chat.message.button.view_summary=View summary | |||
| codemodernizer.chat.message.changes_applied=I applied the changes to your project. | |||
| codemodernizer.chat.message.choose_objective=I can help you with the following tasks:\n- Upgrade your Java 8 and Java 11 codebases to Java 17, or upgrade Java 17 code with up to date libraries and other dependencies.\n- Convert embedded SQL code for Oracle to PostgreSQL database migrations in AWS DMS.\n\nWhat would you like to do? You can enter "language upgrade" or "sql conversion". | |||
| # TODO: make sure all Strings work for Java 21 | |||
There was a problem hiding this comment.
Just checking if there are still more strings to change for Java 21 like some of the error/warning messages
ntarakad-aws
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Support transformations to Java 21.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.