-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DB/SAI) - Fixes quest Counterattack! sometimes not being completed and adds 1 ability to the creature. #21050
base: master
Are you sure you want to change the base?
Conversation
@Exitare if you want to give a test it should always drop the flag. My testing was done via |
@@ -0,0 +1,7 @@ | |||
-- | |||
-- Removes NOT_REPEATABL` and WHILE_CHARMED event_flag, allowing to always drop the flag no matter if it's CC'd or not. | |||
UPDATE smart_scripts SET `event_flags` = `event_flags` &~1 &~512 WHERE `entryorguid` = 23576 AND `source_type` = 0 AND `id` = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back ticks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removes
NOT_REPEATABLE
andWHILE_CHARMED
event_flag
, allowing to always drop the flag no matter if it's CC'd or not fromWarlord Krom'zar
and
Adds
Strike
to theWarlord Krom'zar
sniffed from:4.4.1.58158
and1.15.5.57979
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.