[WIP] CF Faction Assign & Leader Instance Faction #21118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kitzunu
requested changes
Jan 8, 2025
|
Currently, |
|
There is again a lot of code repetition. I would recommend, like Kitzunu, to create function and call that instead. |
Nyeriah
reviewed
Jan 9, 2025
...er/scripts/Northrend/CrusadersColiseum/TrialOfTheChampion/instance_trial_of_the_champion.cpp
Outdated
Show resolved
Hide resolved
github-actions
bot
added
CORE
Exitare
reviewed
Jan 9, 2025
| @@ -280,8 +285,13 @@ class instance_trial_of_the_champion : public InstanceMapScript | |||
| { | |||
| if (TeamIdInInstance == TEAM_NEUTRAL) | |||
| { | |||
| if (Player* gleader = ObjectAccessor::FindPlayer(player->GetGroup()->GetLeaderGUID())) | |||
| TeamIdInInstance = Player::TeamIdForRace(gleader->getRace()); | |||
| if (Group* group = player->GetGroup()) | |||
There was a problem hiding this comment.
Why are you not creating a function for that ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
mod-cfpve not needed anymore
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.