Rename UI camera_entity fields
#17243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it queries the main world for the camera to get the viewport size for the responsive viewport coords resolution. It should be using the main world camera entity.
…racted_camera_entity` and updated the doc comment.
ickshonpe
added
A-UI
BenjaminBrienen
approved these changes
Jan 8, 2025
alice-i-cecile
approved these changes
Jan 10, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
|
@ickshonpe ping me when merge conflicts are resolved :) |
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The
camera_entityfield on the extracted uinode structs holds the render world entity that has the extracted camera components corresponding to the target camera world entity. It should be renamed so that it's clear it isn't the target camera world entity itself.Solution
Rename the
camera_entityfield on each of the extracted UI item structs toextracted_camera_entity.