Proportional scaling for the sprite's texture. #17258
Open
+327
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvestrpredko
force-pushed
the
silvestr/fit-sprite-to-quad
branch
from
68bd63f to
0e7ca6f
Compare
This change introduces new texture scaling options for sprites that maintain aspect ratio: - Add `TextureScale` enum with `FillCenter`, `FillStart`, `FillEnd`, `FitCenter`, `FitStart`, and `FitEnd` modes - Extend `SpriteImageMode` with `ScaleMode` variant to support the new scaling options
Update `Cargo.toml` accordingly.
silvestrpredko
force-pushed
the
silvestr/fit-sprite-to-quad
branch
from
49186a3 to
296174f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Bevy sprite image mode lacks proportional scaling for the underlying texture. In many cases, it's required. For example, if it is desired to support a wide variety of screens with a single texture, it's okay to cut off some portion of the original texture.
Solution
I added scaling of the texture during the preparation step. To fill the sprite with the original texture, I scaled UV coordinates accordingly to the sprite size aspect ratio and texture size aspect ratio. To fit texture in a sprite the original
quadis scaled and then the additional translation is applied to place the scaled quad properly.Testing
For testing purposes could be used
2d/sprite_scale.rs. Also, I am thinking that it would be nice to have some tests for acrates/bevy_sprite/src/render/mod.rs:sprite_scale.Showcase