Merge pull request #58 from blibli-badak/dev-mh

fix har not save any pending response
blibli-badak · Aug 5, 2024 · 38c4574 · 38c4574
2 parents 765505f + a8ac89b
commit 38c4574
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/main/java/com/blibli/oss/qa/util/services/HarEntryConverter.java b/src/main/java/com/blibli/oss/qa/util/services/HarEntryConverter.java
@@ -67,7 +67,7 @@ public void setup() {
 
     public HarTiming convertHarTiming() {
         HarTiming harTiming = new HarTiming();
-        if (timing.isEmpty()) {
+        if (timing == null || timing.isEmpty()) {
             return harTiming;
         }
         harTiming.setDns(timing.get().getDnsStart().intValue());

diff --git a/src/main/java/com/blibli/oss/qa/util/services/NetworkListener.java b/src/main/java/com/blibli/oss/qa/util/services/NetworkListener.java
@@ -242,6 +242,13 @@ public void createHarFile() {
                         time,
                         windowHandle,
                         pair.getResponseBody()));
+                } else {
+                    log.info("Response is null for %s", pair.getRequest().getUrl());
+                    harEntries.add(createHarEntry(pair.getRequest(),
+                        null,
+                        time,
+                        windowHandle,
+                        null));
                 }
             });
         });