refactor: remove outdated prune-block/pruneancient tool, implement it by tail-deletion #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
validator which has used tool |
NathanBSC
reviewed
Dec 17, 2024
eth/backend.go
Outdated
| log.Warn("The node enables PruneAncientData, BlockHistory wille force to 0") | ||
| config.BlockHistory = 0 | ||
| } | ||
| if err = eth.blockchain.PruneBlockHistory(config.BlockHistory); err != nil { |
There was a problem hiding this comment.
run PruneBlockHistory when start nodes?
the prune is not revertable, so I think make user to use it as a tool is better.
when they use this tool, they make their purpose unambiguously
There was a problem hiding this comment.
The node runs as normal in default config(BlockHistory=0), they must set BlockHistory>0 that will trigger the pruning.
|
it would disable the prune-block tool, to avoid impacting the current users, better to be delivered in a separate maintenance release after Pascal hardfork. |
galaio
changed the title
NathanBSC
reviewed
Dec 30, 2024
| @@ -158,7 +158,7 @@ type FreezerEnv struct { | |||
| // AncientFreezer defines the help functions for freezing ancient data | |||
| type AncientFreezer interface { | |||
| // SetupFreezerEnv provides params.ChainConfig for checking hark forks, like isCancun. | |||
| SetupFreezerEnv(env *FreezerEnv) error | |||
There was a problem hiding this comment.
blockHistory is similar to BlobExtraReserve?
if so, maybe can add it as a field of FreezerEnv
|
Good Job! |
refactor: remove outdated prune-block tools;
freezer: support reset tail meta when restarting from pruned ancient;
galaio
force-pushed
the
remove-prune-block
branch
from
a13f681 to
70d074f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will remove prune-block/pruneancient tool, it can be replaced by tail-deletion, which is more easy & efficient for managing block history.
The PR will auto-detect the legacy offset metadata from db, and reset the tail metadata of freezer tables. So it's safe to run
--history.blockswith the old pruneancient/prune-block feature.Changes
Notable changes: