MIDI playback support with custom SoundFonts #3613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pylint result on modfied files: |
EmoonX
commented
Dec 18, 2024
TheEvilSkeleton
requested changes
Dec 19, 2024
|
Just a question, apologies as I haven't built & tested myself. Is the scope for the whole bottle only, or can the options be set per program? My use-case would be to have multiple shortcuts to the same game in the same bottle with different soundfonts. |
|
@keenanweaver Funnily enough, right now it's actually the other way around: you are able to set different soundfonts for each program (i.e what you need), but there isn't a global soundfont chooser. Shouldn't be hard though to add that option in a commit up next. I'm just not sure yet about bundling a default one. |
|
I'm pretty much all Nuked SC55 these days, but before that I used the Trevor0402 SC-55 soundfont. It's really tough finding a 'universal' soundfont when it sounds incredible in one game and terrible in another. Like most things, my default barometer is Doom--if it sounds good there, it probably sounds good in other games. I'm of the opinion one shouldn't be bundled in here. People that will use this feature know what they're wanting, and those dipping their toes into the soundfont pond for the first time will easily find discussions and recommendations all over the web. |
I like the reasoning. On the one hand, it could feel kinda incomplete not having a required feature working out-of-the-box. On the other hand, MIDI audio playing by default would make some people unaware of even the option to swap it for a custom soundfont ("this game sounds so bad and apparently I can't do anything about it" moment). For the best of both worlds, perhaps we could simply leave the default setting empty ( |
EmoonX
force-pushed
the
midi-playback
branch
from
fd109b5 to
e0613a1
Compare
EmoonX
force-pushed
the
midi-playback
branch
from
e0613a1 to
75f1462
Compare
EmoonX
force-pushed
the
midi-playback
branch
3 times, most recently
from
4205cfc to
d442151
Compare
EmoonX
force-pushed
the
midi-playback
branch
2 times, most recently
from
013a6c7 to
a1c9b2b
Compare
|
I think that's it. All functionalities should work as described. As for the rest, a global MIDI settings menu is in the plans. We can then have stuff like:
But that's definitely better left for another PR further on. This one got too |
Done through garbage collector's reference counting. In case of multiple programs running with the same soundfont at once, instance is only terminated after ALL of them exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing a new launch option as a GUI-oriented user-friendly way to deal with MIDI playback, for programs (mainly old games) that contain MIDI sequencer audio tracks.
Makes use of FluidSynth as MIDI synthesizer, and
PipeWireALSA as the audio driver (though PulseAudio and Pipewire also work). An user-supplied SoundFont file is required (either in.sf2or.sf3formats — both tested to work). This allows different games to be run individually and simultaneously with distinct instrument sets.A registry add/update is also applied, to make the game pick the right instrument set at launch (when more than one fluidsynth instance is running at once). See: https://gitlab.winehq.org/wine/wine/-/wikis/MIDI#selecting-the-output---the-midi-mapper
Of course, and most importantly, this PR will probably require
fluidsynthlibfluidsynthand its related libraries to be bundled as part of Bottles's flatpak. Correlated issue: flathub/com.usebottles.bottles#466Type of change
How Has This Been Tested?
First of all, make sure
fluidsynthis installed on your systemlibfluidsynthand its related libraries (libinstpatch-1.0,libportaudio,libportaudiocpp) are installed and reachable from the flatpak sandbox.Set the
MIDI SoundFontlaunch option for a MIDI-driven game, choosing a .sf2/.sf3 file as you wish. MIDI playback should now work and a FluidSynth server will start upon launch.Setting another SoundFont for a different game — and running it without closing the first — will have said game playing audio with the second instrument set, by running another FluidSynth instance. Both should coexist without interference.
Closing any of the games should kill the respective fluidsynth instance. Further loaded instances will be given the vacant IDs of past ones (e.g by having three distinct-SoundFont open games — #0, #1 and #2 — and closing the one with instrument set #1, next game with unique SoundFont will be given ID #1).