envvars-dialog: Allow to paste var=value and fix validation #3679
Conversation
jntesteves
commented
Jan 7, 2025
•
jntesteves
commented
- Rework the envvars dialog to allow copy/pasting complete variable assignments instead of having to input first the name and later the value.
- Fix the input validation which had some inverted logic and make it behave as expected.
- Make the panel leaner by removing unnecessary headers and periods at the end of labels.
- Port to AdwDialog
* Rework the envvars dialog to allow copy/pasting complete variable assignments instead of having to input first the name and later the value. * Fix the input validation which had some inverted logic and make it behave as expected. * Make the panel leaner by removing unnecessary headers and periods at the end of labels.
jntesteves
force-pushed
the
sane-envvars-dialog
branch
from
fae1add to
35c77c5
Compare
Traverse AdwEntryRow's widget tree to remove visibility of the title labels and change alignment of the text entry to center. This implementation is tightly coupled with the internal representation of AdwEntryRow. Checks were added to prevent crashing if that representation changes, but in such case the layout may get askew.
jntesteves
force-pushed
the
sane-envvars-dialog
branch
from
8b17cfc to
a711a4f
Compare
| action: "action(window.close)"; | ||
| } | ||
| } | ||
| template $EnvVarsDialog: Adw.Dialog { |
There was a problem hiding this comment.
I think it'd be best to change the name of the dialog to BottlesEnvironmentVariablesDialog. It's definitely long, but I think avoid abbreviations helps the readability. Prefixing with Bottles is also important because libadwaita and GTK follow the same convention.
There was a problem hiding this comment.
Those libs use their namespaces because they are shared across many projects, but I don't think we need to do that in client code, it's all obviously Bottles, the prefix is unnecessary IMO. I used just EnvironmentVariablesDialog like the rest of our classes, I think that's better.
There was a problem hiding this comment.
Fair enough. I personally prefer the namespace for consistency reasons and increased readability in the inspector, but I guess I will have to change it back to how it was everywhere else
| @@ -2,12 +2,12 @@ using Gtk 4.0; | |||
| using Adw 1; | |||
|
|
|||
| template $EnvVarEntry: Adw.EntryRow { | |||
There was a problem hiding this comment.
This should be renamed to BottlesEnvironmentVariableEntry.
jntesteves
force-pushed
the
sane-envvars-dialog
branch
2 times, most recently
from
704fc2b to
56f959d
Compare
