Added support for Ghostty #3683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple change, worked fine. Small note: I don't know why the other terminals require the 'sh -c' or 'bash -c', but Ghostty calls that already when passing the option '-e'. worked fine in my machine without that, but it would be nice if someone else tested it just to make sure.
|
@TheEvilSkeleton looks like something to patch up with the recent patches to focus on the Flatpak. |
|
I didn't even know we had that code around. I wouldn't mind merging this because it's the backend side of things, but I'm not entirely sure if the code is even correct? |
|
I think the bigger issue is that we're hard coding all these terminals, when we should instead be letting the user set it themselves |
That was actually my first thought upon seeing this code. Personally, I think it would be nicer to have a setting like "terminal command" in which I setup the command that works for my emulator, whatever it may be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for running applications using Ghostty.
Note: I don't know why the other terminals require the 'sh -c' or
'bash -c', but Ghostty calls that already when passing the option '-e'.
It worked fine in my pc without that, but it would be nice if someone
else tested it just to make sure.
Type of change
How Has This Been Tested?
Worked fine here, but as I mentioned further testing would be nice.