Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Galea channels 7 and 8 to EMG #702

Merged

Conversation

isaacplotkin
Copy link
Contributor

The team wants to change channels 7 and 8 to EMG as the default setting for Galea Beta.

@Andrey1994 Andrey1994 self-requested a review January 22, 2024 16:08
Copy link
Member

@Andrey1994 Andrey1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to do the same for serial board and maybe need ti change gains in gain tracker and in code for parsing

@isaacplotkin
Copy link
Contributor Author

isaacplotkin commented Jan 22, 2024

beta_default_hardware_settings

Updated gain tracker to reflect new defaults in Galea GUI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to change default values in constructor

@isaacplotkin isaacplotkin force-pushed the update-galea-default-emg branch from ef68a99 to fa5941f Compare January 22, 2024 19:08
@retiutut
Copy link
Member

Confirming these are correct changes. Thanks @isaacplotkin

@Andrey1994 Andrey1994 self-requested a review January 22, 2024 19:21
@Andrey1994 Andrey1994 merged commit 97f11c8 into brainflow-dev:master Jan 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants