Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goreleaser config for setting version number #47

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jhump
Copy link
Member

@jhump jhump commented Nov 27, 2023

This isn't a real issue in practice since the default value of the var should be correct. This configuration for goreleaser is only in place in the off-chance that we tag a sha where the var has not been correctly updated. In that case, both make install and goreleaser will update the var so the built binary emits the correct version.

This was using the wrong package because I forgot to update this config in #37, when this var was moved out of the main package into an internal app package.

@jhump jhump requested a review from srikrsna-buf November 27, 2023 16:34
@jhump jhump merged commit 9dcf964 into main Nov 28, 2023
3 checks passed
@jhump jhump deleted the jh/fix-goreleaser-config branch November 28, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants