Update to wasmtime v28 #416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also tackled the build failures in #408 -- my goal was to merge that one first. It's stuck on windows CI failing on Ruby 3.4, but pre-built binaries still work. I investigated but not sure how to move forward, so we could allow Ruby 3.4 to fail on Windows until we get it fixed. Thoughts? |
jbourassa
approved these changes
Jan 8, 2025
|
Sure let's merge #408 first, happy to review when you feel it's ready.
Just to make sure I fully understand: if we allow Ruby 3.4 to fail on CI, we won't need to exclude it from the pre-built binaries included in the release assets? Is that correct? |
|
Correct. The pre-built binaries use a docker image to build, they don’t run
on an actual Windows machine (unlike CI).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.