Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add language filter function for case studies #1522

Open
wants to merge 3 commits into
base: case-studies
Choose a base branch
from
Open

feat: Add language filter function for case studies #1522

wants to merge 3 commits into from

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Jan 22, 2025 •
edited
Loading

Done

  • Add language and clear filter option on index page

QA

  • Clone this branch locally and go to /case-study
  • Make sure you have DISCOURSE_API_KEY and DISCOURSE_API_USERNAME set in ur local env, if you need the API key and username let me know
  • Select a language from filter dropdown
  • Check that it only shows case studies in that language, clear filter and check that it shows all case studies

Issue / Card

Fixes WD-17516

Screenshots

[if relevant, include a screenshot]

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@petesfrench
Copy link
Contributor

It would be nice to show some kind of 'No results found' message for languages that don't have any case-studies (assuming that's why none are showing here:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petesfrench petesfrench Awaiting requested review from petesfrench

Assignees
No one assigned
Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@britneywwc @webteam-app @petesfrench