Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: /lxd/manage modal #1527

Merged
merged 1 commit into from
Jan 25, 2025
Merged

fix: /lxd/manage modal #1527

merged 1 commit into from
Jan 25, 2025

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Jan 24, 2025 •
edited
Loading

Done

  • Fixed incorrect modal call
  • Drive by: fixed misplaced hr showing up twice above list

QA

  • View the site locally in your web browser at: https://canonical-com-1527.demos.haus/lxd/manage
  • Click the "Talk to our LXD experts" cta and see that the modal opens as expected
  • Under the "Third-party integrations" see that there is not a duplicate hr above the Ansible list items

Issue / Card

Fixes #

Screenshots

[if relevant, include a screenshot]

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@mtruj013 mtruj013 changed the title Fix modal and duplicate hr fix: /lxd/manage modal Jan 24, 2025
@akbarkz akbarkz merged commit 86ef10f into canonical:main Jan 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akbarkz akbarkz akbarkz approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtruj013 @webteam-app @akbarkz