[DPE-4375] Add cluster manual re-join handler #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinclert-canonical
requested review from
paulomach,
shayancanonical and
carlcsaposs-canonical
sinclert-canonical
force-pushed
the
sinclert/4375/cluster-manual-rejoin
branch
2 times, most recently
from
4f14207 to
b1e5454
Compare
carlcsaposs-canonical
approved these changes
Jan 22, 2025
paulomach
reviewed
Jan 22, 2025
There was a problem hiding this comment.
@sinclert-canonical What's the idea for a integration test?
I think we could do the following:
Would you mind doing a pairing session with me? I would like to avoid hours of CI time just to validate the integration test. |
sinclert-canonical
force-pushed
the
sinclert/4375/cluster-manual-rejoin
branch
from
bd8292d to
c909fbf
Compare
sinclert-canonical
force-pushed
the
sinclert/4375/cluster-manual-rejoin
branch
from
c909fbf to
41173b0
Compare
|
Branch rebased from |
shayancanonical
approved these changes
Jan 24, 2025
shayancanonical
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to manually re-join a MySQL replica that has gone
OFFLINE, to the cluster, whenever MySQL 8.0.21+ auto re-join attempts have been exhausted.Description
There are edge cases where a MySQL instance that has lost connection to the cluster it originally belong to (i.e.
OFFLINE), exhaust its automatic retries (by default 3 retries, with 5 mins between each, starting with MySQL 8.0.21). For those cases, a manual re-join should be performed.