tests: fix snapd-refresh-undo test for beta validation #14980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens on beta validation that /var/lib/snapd/snaps/snapd_x1.snap doesn't exist and there is a snapd snap with the beta revision instead of x1.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14980 +/- ##
=========================================
Coverage ? 78.26%
=========================================
Files ? 1158
Lines ? 153703
Branches ? 0
=========================================
Hits ? 120288
Misses ? 26012
Partials ? 7403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Fri Jan 24 23:12:29 UTC 2025 Failures: |
ernestl
approved these changes
Jan 25, 2025
| cp /var/lib/snapd/snaps/snapd_x1.snap ./snapd.snap | ||
| else | ||
| # Beta validation has a different snapd version | ||
| cp /var/lib/snapd/snaps/snapd_*.snap ./snapd.snap |
There was a problem hiding this comment.
Would this not cover both cases? Is ot required to be specific with edge where we expect x1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens on beta validation that /var/lib/snapd/snaps/snapd_x1.snap doesn't exist and there is a snapd snap with the beta revision instead of x1.