-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CERTTF-457] feat: Github action for retrieving data from multi-device jobs #434
Open
boukeas
wants to merge
11
commits into
main
Choose a base branch
from
CERTTF-457-multi-device-polling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi George, sorry about the late response.
|
I think I am using agent and queue terminology wrong in my thinking, let me do some tests and I will try to make better comments. |
@boukeas One important issue is that the job reports all done before devices are reserved job output
status of jobs in Testflinger
|
boukeas
force-pushed
the
CERTTF-457-multi-device-polling
branch
from
January 22, 2025 11:15
a9a7fab
to
98e8f6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a Testflinger Github action that polls a multi-device job (receiving its ID as its input) and returns the job IDs and machine IPs of its child jobs as a JSON string.
Resolved issues
Resolves CERTTF-457.
Tests
The workflow below was used to submit a multi-device job without polling, use the
poll-multi
action to retrieve the data for the child jobs, and then display that data and confirm it's valid JSON.Here is a successful test run. This is the output of the action:
A syntactically incorrect version of the job was also submitted, to test that the action detects provisioning (i.e. allocation) failures for multi-device jobs.