Sort Order Improvements for the Agents table #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excited for this, would you mind including a screenshot(s) in this review so can quickly review UI changes? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds some improvements to the agents table - namely the provisioning streak column. This PR makes the sorting functionality of the table work with this column, first separating by failures/success, then sorting by the streak number. In addition, url parameters were added to persist sorting information on refresh for the agents table. Finally, this column was given the name
"Outcome",and a tooltip was added describing this column.To support this, new functions were added to filter.js - ordering functions were created to differentiate default ordering with provision streak ordering. Also, a new function to get URL parameters and use them to sort the table was also created. Finally, the sortTable function was split into two functions - sortTable and cycleTableSort. sortTable now just sorts a table given an ordering("ascending", "descending", "none"), while cycleTableSort cycles through the ordering states and uses sortTable to apply that ordering.
Resolved issues
Resolves https://warthogs.atlassian.net/browse/CERTTF-396
Documentation
Each new function was given documentation and comments.
Web service API changes
N/A
Tests
N/A