-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certified encodings for proof logging #248
Open
chrjabs
wants to merge
64
commits into
next-major
Choose a base branch
from
proof-logging
base: next-major
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactors totalizer database to its own module - adds `pidgeons` library for writing VeriPB proofs - adds the ability to write a certificate of correctness while building the totalizer encoding
feat: proof logging gte
feat: cadical proof tracer interface
the aim is to avoid memory allocations as much as possible
rather than eagerly converting clauses (and assignments) to rustsat types in CaDiCaL proof tracer interface, do that lazily only if the user uses them
}; | ||
} | ||
|
||
impl super::Db { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: method `ensure_semantics` is never used
--> src/encodings/totdb/cert.rs:349:12
|
37 | impl super::Db {
| -------------- method in this implementation
...
349 | pub fn ensure_semantics(
| ^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
chrjabs
force-pushed
the
proof-logging
branch
from
January 21, 2025 15:27
b9676b2
to
db746f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Contribution
This work is part of an upcoming paper.
PR Checklist
CONTRIBUTING.md
rustfmt
/cargo fmt --all
next-major
branch, not againstmain