Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed automated tests entry point on Windows. #1062

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed automated tests entry point on Windows. #1062

wants to merge 2 commits into from

Conversation

martnpaneq
Copy link
Contributor

Suggested merge commit message (convention)

Internal: Fixed automated tests entry point on Windows. Closes ckeditor/ckeditor5#17797.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

psmyrek
psmyrek reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@psmyrek psmyrek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but now we do not need to manually replace \ with /.

Using the upath.posix.* namespace is not needed.

Also, upath is not added to dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psmyrek psmyrek psmyrek left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Script for automated tests in ckeditor5-dev-tests package does not exclude ignored paths on Windows
2 participants
@martnpaneq @psmyrek