Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fullscreen mode feature bootstrap #17810

Open
wants to merge 5 commits into
base: ck/epic/1235-fullscreen-mode
Choose a base branch
from
Open

Fullscreen mode feature bootstrap #17810

wants to merge 5 commits into from

Conversation

Dumluregn
Copy link
Contributor

@Dumluregn Dumluregn commented Jan 24, 2025 •
edited
Loading

Suggested merge commit message (convention)

Internal (fullscreen): Introduce a fullscreen mode feature.

Additional information

This PR contains a package bootstrap and a basic working feature.

What should work:

  • command/button state
  • basic layout (sticky menu bar + toolbar, visible sidebars, editable area)
  • support for both Classic and Decoupled editor
  • all UI elements should be usable in fullscreen mode (dialogs, panels, balloons, tooltips etc)

What is not a subject of this PR:

  • premium features integrations
  • unit tests
  • feature will be renamed to fullscreen instead of full-screen
  • icon validation fails but it's just temporary one anyway (auto-fix via script didn't help).

@Dumluregn Dumluregn changed the title Ck/fullscreen bootstrap Fullscreen mode feature bootstrap Jan 24, 2025
@Dumluregn Dumluregn force-pushed the ck/fullscreen-bootstrap branch from 508b9ff to 3a8bc6d Compare January 24, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dumluregn