Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby version #1204

Merged
merged 4 commits into from
Apr 4, 2022
Merged

Update ruby version #1204

merged 4 commits into from
Apr 4, 2022

Conversation

oshiro3
Copy link
Contributor

@oshiro3 oshiro3 commented Mar 29, 2022

ruby version を 3.1.1 に上げました

psych の 4 系が ruby 3.1 に対応していないため明示的に 4 未満を設定しました

spec 実行時 CSRF 関連の warning が出ますが rails 7.1 に向けた警告らしく、config の値は適正であるため無視しています
https://github.com/rails/rails/pull/43817/files

@oshiro3 oshiro3 requested review from jacopen and takaishi March 29, 2022 13:15
@oshiro3 oshiro3 self-assigned this Mar 29, 2022
@dreamkast-cloudnativedays
Copy link
Contributor

Copy link
Collaborator

@jacopen jacopen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIがこけちゃってるので確認おねがいします!

@oshiro3
Copy link
Contributor Author

oshiro3 commented Apr 4, 2022

これ自分のローカルではキャッシュのせいかなぜか通っていたんですが、どうやら debase が 3.1 に対応していないようです
ruby-debug/debase#95
ruby-debug/ruby-debug-ide#223 (comment)
今のところ対応策としては ruby-debug-ide を無効化するくらいしかなく、しばらく止めておくのがよいように思います

@oshiro3 oshiro3 force-pushed the update-ruby-version branch from 7a8df58 to 115b2d0 Compare April 4, 2022 11:04
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Simplecov Report

Covered Threshold
55.92% 25%

@oshiro3 oshiro3 requested a review from jacopen April 4, 2022 11:33
@jacopen jacopen merged commit e8f9355 into main Apr 4, 2022
@jacopen jacopen deleted the update-ruby-version branch April 4, 2022 13:45
onk added a commit that referenced this pull request Jul 3, 2024
This setting is already configured in `config/application.rb` (PR #1204).

We will adopt the default behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants