Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update column.h + flush stdout in sqllogictest #646

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Update column.h + flush stdout in sqllogictest #646

merged 2 commits into from
Nov 5, 2023

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Nov 2, 2023

DO NOT PUSH PROJECT SOLUTIONS PUBLICLY.

And especially do NOT open pull requests with project solutions!

Please be considerate of this free educational resource.

@skyzh skyzh requested a review from yliang412 November 2, 2023 02:08
@skyzh
flush stdout
fb7734c 
Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh changed the title Update column.h Update column.h + flush stdout in sqllogictest Nov 2, 2023
yliang412
yliang412 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@skyzh skyzh merged commit cdf3ed0 into master Nov 5, 2023
3 checks passed
@skyzh skyzh deleted the skyzh-patch-3 branch November 5, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yliang412 yliang412 yliang412 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyzh @yliang412