Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(f24 p1): update Evict function doc for std::optional return type #799

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(f24 p1): update Evict function doc for std::optional return type #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/buffer/lru_k_replacer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ LRUKReplacer::LRUKReplacer(size_t num_frames, size_t k) : replacer_size_(num_fra
* Successful eviction of a frame should decrement the size of replacer and remove the frame's
* access history.
*
* @return true if a frame is evicted successfully, false if no frames can be evicted.
* @return the frame ID if a frame is successfully evicted, or `std::nullopt` if no frames can be evicted.
*/
auto LRUKReplacer::Evict() -> std::optional<frame_id_t> { return std::nullopt; }

Expand Down