Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support clang 18 #801

Merged
merged 3 commits into from
Jan 26, 2025
Merged

Support clang 18 #801

merged 3 commits into from
Jan 26, 2025

Conversation

rmboyce
Copy link
Contributor

@rmboyce rmboyce commented Jan 24, 2025 •
edited
Loading

Allow BusTub to build on Clang 18 (I know Clang 14 is officially recommended, but I thought it would still be nice if it built on Clang 18).

Changes:

  • Update version of third-party library fmt, as it was causing compiler warnings (that get converted to errors by the compile flags)
  • Include fmt/ranges.h in files that needed fmt::join, as this was split off in the fmt library
  • Miscellaneous small changes to files that gave compile errors on Clang 18

@rmboyce rmboyce changed the title Bump fmt version to latest Support clang 18 Jan 25, 2025
@rmboyce rmboyce marked this pull request as ready for review January 25, 2025 20:11
yliang412
yliang412 approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One other thing we could do is to include clang-18 in the CI. But we can do it maybe in another PR.

@rmboyce rmboyce merged commit 45bdaaf into master Jan 26, 2025
3 checks passed
@rmboyce rmboyce deleted the rboyce/bump-fmt branch January 26, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yliang412 yliang412 yliang412 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmboyce @yliang412