Add a mypy workflow to check changed files only #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerrySentry
changed the title
.github/workflows/mypy.yml
Outdated
| static-type-check: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 |
.github/workflows/mypy.yml
Outdated
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-python@v3 | ||
| with: | ||
| python-version: '3.10' |
There was a problem hiding this comment.
Why are we using 3.10 here as both API and worker are moving/have moved to 3.12
There was a problem hiding this comment.
Oh right we're on 3.12 now
.github/workflows/mypy.yml
Outdated
| @@ -0,0 +1,25 @@ | |||
|
|
|||
There was a problem hiding this comment.
nit: extra space
trent-codecov
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will do a mypy type checking for all changed python files in the PR. The specific mypy configurations will be stored in the individual repos that invoke this action.