Set Node version in a single place #6534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it much easier to update. Also use 18.15.0 specifically since that is what VS Code ships with.
code-asher
force-pushed
the
node-version
branch
from
45a5cbf to
61db2fa
Compare
yiliang114
pushed a commit
to yiliang114/code-server
that referenced
this pull request
Jan 23, 2025
This should make it much easier to update. Also use 18.15.0 specifically since that is what VS Code ships with. Additionally, it fixes the post-install script being skipped due to a Yarn v1 bug that happens when Yarn installs node-gyp, which it does because 18.18 onward stopped bundling node-gyp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it much easier to update. Also use 18.15.0 specifically since that is what VS Code ships with.
It might also fix the issue with Yarn skipping the post-install because that happens when it needs to install node-gyp and node-gyp stopped being bundled from 18.18 onward. We will need to address this at some point though.